Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add api call createConsoleEndpoint #78

Merged
merged 16 commits into from
Mar 13, 2024
Merged

add api call createConsoleEndpoint #78

merged 16 commits into from
Mar 13, 2024

Conversation

sbrueseke
Copy link
Contributor

No description provided.

@sbrueseke
Copy link
Contributor Author

@weizhouapache @rohityadavcloud can you please review this PR?

@rohityadavcloud
Copy link
Member

ping @shwstppr @vishesh92 can you review and advise on this PR, thanks. @sbrueseke has advised me privately that they need this for some use with the cloudstack packer plugin.

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@vishesh92 vishesh92 merged commit 26f7939 into apache:main Mar 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants